Comments on Lab 8

 

 

1.      The labeling on your output from ThingDriver should be improved.

2.      The labeling oy your output from CircleTester should be improved

3.      You forgot to put your name in the comment field of your submission to Blackboard -1

4.      Your comments are present in ThingDriver but erroneous.

5.      Methods should have only 1 return statement , your Circle.java has 2.

6.      You proved that the value of z in one, two, and three is the same.  You did not prove that the values of x and y are different in each.

7.      You used this.  in Thing.java but not in Circle.java 

8.      When the directions on the worksheet say "Call the toString method and print the result", I am not asking you to show me the code which does this, I am asking you what will be output when the code is run.

9.      Your output shows 3 separate values of x; 3 separate values of y; but only 1 value of z. but your answer in 4.12 says there were 3 separate values of z.

10.  You should NEVER EVER compare the value in an IF statement to true.  This will cost you BIG points if I see it in your programs          if(mySecondCircle.greaterThan(myFirstCircle)== true)

The statement should be

     if(mySecondCircle.greaterThan(myFirstCircle)

11.  If all three x values or all three y values were the same at the end of your program, you didn't follow the directions carefully enough

12.  Your static variable count in Thing.java counts the number of instantiations but it doesn't show the x-values of one, two, and  three.

13.  Why are you using keyboard.nextInt() to pick up a value to be stored in a double?

14.  For the value you used for the radii of the two circles you got the right answer as to their relative sizes..  For the values I used, you didn't.  Please see comments on Blackboard for your submission.

15.  Why did you make radii int  CircleTester.java  ints when they are doubles in Circle.java?

16.  Why do you have a private Circle circle inside your Circle.java class?

17.  Why did you hard code values into your program when it said to get the data from the user?

18.  Why did you make your Circles static in CircleTester.java?

19.  One of the style rules you ignored is to declare variables and instantiate them in separate statements!!!

20.  You did things in the class CircleTester that the specs said were to be done in the class circle: testing for greater than.  -5

21.  The results for the test of equality should have been printed along with the results for greaterThan.