Program 2 specific things

  1.  

Specification says numbers must be integers. It does not say they must be positive integers
  1.  

The program specification says it should handle 3 numbers.  It does not imply a loop is needed.
  1.  

Double sided tape to hold label to disk isn’t a good idea
  1.  

Introduction is  too short - doesn’t completely describe work of program
  1.  

Output is not spaced properly
  1.  

Sorted data is not in descending order
  1.  

Program shouldn’t bomb on erroneous data – it should end gracefully
  1.  

Program has no introduction to user
  1.  

Output is unlabeled
  1.  

Not conforming to the specifications – (i.e requiring spaces between numbers or 0 to quit)
  1.  

Inadequate commenting
  1.  

Intro doesn’t describe expected format of input – which is important

 

 

 

 

General things that can cost you points

1

No label on folder

2

No label on disk

3

Language not correctly specified

4

Environment not correctly specified

5

Compiler not correctly specified

6

Wrap around on printout

7

Executable not on disk

8

Due date not correct

9

All output should be labeled

10

Input not described

11

Output not described

12

Subroutines should follow end statement of main program

13

Subroutines should have a RETURN statement

14

Comments are inadequate

15

Input description not standard

16

Output description not standard

17

Heading incomplete

18

Don’t use PRINT *  , READ * , WRITE (6,*) or READ (5,*)

19

Although you had an executable on your disk, it couldn’t be run (disk problem)

20

Wrong kind of folder – folder must have pockets for disk

21

Disk not turned in

22

Description doesn’t match problem

23

Careful of spelling

24 

Your output doesn’t have spaces between the values & is hard to read

25

You should have a SWAP subroutine instead of repeating inline code

26

Don’t add handwritten comments include them in the listing

27

No folder

28

Descriptions missing

29

Input MUST be echoed (unless otherwise specified)

30

You have an unused variable in your subroutine

31

You appear to have un-necessary initializations

32

You are missing a 1X, in your output FORMAT statement

33

Prompt isn’t precise enough

34

You should have declared X,Y, and Z as integers

35

You are missing SWAP

36

Your parameter list is not correctly indicated

37

You are assigning REAL values to INTEGER variables

38

Subprogram should not reference main program variables

 

 

 

 

Other things I noticed

A

Real variables beginning with a-h,o-z don’t have to be declared

B

You should have observed something interesting that occurred in your program

C

Nice use of arrays but FORTRAN I required a DIMENSION statement

D

Integer variables beginning with i..n don’t have to be declared

E

All your FORMAT statements were identical. You can re-use them

F

Your commenting is what I was looking for

G

Nice use of  same FORMAT for different READ statements

H

Nice use of a subroutine to print out the values

J

Nice use of a subroutine to get the values

K

Your comments about what you found are excellent

L

Your remarks about problems are excellent

M

Telling the user what the program will do is the way to go

 

Neat Observations

I

If enter less than required 3 values missing values will be 0

 

Need to ask for what you want…

 

***** means that number is too big for format

 

Cmd  -o Test.exe will change the output file name to desired name (in GNU g77)